Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

整理: 辞書単語テストの形式を統一 #1443

Merged
merged 5 commits into from
Jun 28, 2024
Merged

整理: 辞書単語テストの形式を統一 #1443

merged 5 commits into from
Jun 28, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 27, 2024

内容

辞書単語テストの形式を統一し docstring を充実させるリファクタリングを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner June 27, 2024 05:38
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 27, 2024 05:38
Hiroshiba
Hiroshiba reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！

ドキュメントのとこだけコメントしました。
平易で普遍的な言い回しを･･･！

（将来的にリファクタリングはレビューなしでも良いのかなと思っていて、そうなると言い回しがどんどん複雑化してしまうかもなので、何度もコメントしています 🙇 ）

test/unit/user_dict/test_user_dict_model.py Outdated Show resolved Hide resolved
test/unit/user_dict/test_user_dict_model.py Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented Jun 28, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Hiroshiba
Hiroshiba approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit 925c4d5 into VOICEVOX:master Jun 28, 2024
4 checks passed
@tarepan tarepan deleted the refactor/dict_word_test_format branch June 28, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarepan @Hiroshiba