Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
問題ないと思うのでマージします！
|
|
成功してそうでした！！ ということで不要になったvvppp側は削除します 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決プルリクエストです。
関連 Issue
close #1174
その他
wc -lの結果が、macの時だけ数字の前にタブ？が含まれているのが挙動が変になってる理由です。-eqは数字比較用、==は文字列比較用らしく、-eqにすれば数字として扱ってくれるので空白を無視してくれる感じでした。trで空白を除去するのがいいのか、数字として扱って空白を無視するのがいいのか、どっちの方がいいのか難しいところですが、まあ数字の比較をする時は-eqを使うのがいいらしく、それで解決するっぽいのでこっちに倒しました。。