Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
|
たぶん問題ないと思うのでマージします！ そもそもこの変更が生じないのがベストだと思うので、どうにかできないかというissueを作ってみました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
lockファイルに変更があったらしく、何もしていないのにテストが落ちてしまう状況になっているぽいので修正します。
その他
そもそもの問題として、lockファイルは外部要因に応じて勝手に変わりうるものっぽいです。
なので今のようにworkflowで完全一致することを毎回判定するのはよくなさそう。
例えばpyproject.yamlが変わった時だけlockに差がないか確認する、とかが良さそう？