Fix the issue found in Flatten #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old flatten used recursion and was hard to debug. Fix it by mapping order-N tensor to order 3 tensor (before_n, n, after_n) then do transpose in copy.
|
@kshitij-05 have a look at the remaining failures, all seem to be ZCP (no more CP failures), indeed perhaps sitting too close to the edge? |
|
@evaleev @kshitij-05 I believe I was able to fix the issue. Looks like it was a near rank problem. I just turned up the rank slightly for these problems (I increased the rank by 2) |
evaleev
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue found in calling
update_w_KRPwithout MKL see #167. To fix the problem I no longer call the flatten function. Now I just push the transpose work on thecontractfunction. I also rewrote the Flatten code to work properly by taking an order-N tensor and flattening it to an order-3 tensor with dimensions(modes_before_n, n, modes_after_n)and then I "permute" the tensor into the flattened order during the copy stage.