Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New UI Layout Management #6

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat: New UI Layout Management #6

merged 3 commits into from
Feb 24, 2025

Conversation

Valkyrie00
Copy link
Owner

This pull request includes significant refactoring to the AppService class in the internal/services package, focusing on removing the LayoutService and integrating its functionality directly into the AppService. The changes improve the structure and readability of the code by consolidating layout management.

Key changes include:

Integration of Layout Management:

  • Removed LayoutService and integrated its functionalities directly into AppService. (internal/services/app.go, internal/services/io.go) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Simplification of Notification and Modal Handling:

  • Replaced LayoutService notification methods with direct calls to layout.GetNotifier(). (internal/services/app.go, internal/services/io.go) [1] [2]
  • Introduced showModal method in AppService for handling modal dialogs. (internal/services/io.go)

Enhancement of Search and Table Handling:

  • Replaced LayoutService search field and result table methods with direct calls to layout.GetSearch() and layout.GetTable(). (internal/services/app.go, internal/services/io.go) [1] [2] [3] [4] [5]

Removal of LayoutService:

  • Deleted layout.go file and all associated methods and interfaces for LayoutService. (internal/services/layout.go)

These changes streamline the code and reduce redundancy by consolidating layout-related functionalities into the AppService class, enhancing maintainability and readability.

@Valkyrie00 Valkyrie00 added the enhancement New feature or request label Feb 24, 2025
@Valkyrie00 Valkyrie00 self-assigned this Feb 24, 2025
@Valkyrie00 Valkyrie00 merged commit 7d2c082 into main Feb 24, 2025
1 check passed
@Valkyrie00 Valkyrie00 deleted the feat/ui branch February 24, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant