steamcompmgr: Use XInput2 RawMotion events as a hint to update cursor pos #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pos Taking a page out of XEyes' book to get the cursor position (even when the cursor is grabbed, etc) by only doing so when we get a RawMotion event -- and only register for those when we know there's a cursor image that we would want to render. This is a kinda crap workaround for the fact that we cannot directly just recieve information about the cursor from the XServer, even as the X11 WM due to cursor grabbing, input masking and other such nonsense. An alternative would be using something like libei and having XTest funnel through that -- however that needs work to be functional on nested compositors.
|
I did some profiling comparing the gamescope-xwm thread's hotspots w/ gamescope/master -> gamescope/xinput2-cursorevents. This PR seems to get rid of all of the MouseCursor:: related hotspots. |
|
I can also confirm that this runs fine and this gets rid of all the round trips spent in XQueryPointer. A part of the cost is moved to reading the events instead, but looking at the profile this should be easily a 25% work reduction overall on the xwm thread. |
|
Well, that cost should only be incurred when the cursor is visible given we set/unset the mask. Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a page out of XEyes' book to get the cursor position (even when the cursor is grabbed, etc) by only doing so when we get a RawMotion event -- and only register for those when we know there's a cursor image that we would want to render.
This is a kinda crap workaround for the fact that we cannot directly just recieve information about the cursor from the XServer, even as the X11 WM due to cursor grabbing, input masking and other such nonsense.
An alternative would be using something like libei and having XTest funnel through that -- however that needs work to be functional on nested compositors.