Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow disabling script installation #1578

Conversation

matte-schwartz
Copy link

@matte-schwartz matte-schwartz commented Oct 11, 2024

Should fix: #1575

actually now that i'm taking a closer look at src/meson.build there's probably a better way to do this change...

@layercak3
Copy link

layercak3 commented Oct 13, 2024

actually now that i'm taking a closer look at src/meson.build there's probably a better way to do this change...

Well, the install script could be replaced with install_subdir('scripts', install_dir : join_paths('share', 'gamescope')) (/usr/share/gamescope is hardcoded so shouldn't use data_dir), but I guess it was done using a shell script so that lua scripts removed fro the repo would be removed in the install prefix, in case someone is installing directly to / instead of cleaning and using a destdir for a distro package? (in this case, we might want to make it so that rm -rf "${DESTDIR}/${MESON_INSTALL_PREFIX}/share/gamescope/scripts" || true is always run regardless of whether the option is set, perhaps by moving it into a separate script, so that scripts are removed in case someone installing directly to / later disabled the option)

@misyltoad
Copy link
Collaborator

Yes, it was done in a script to clear out old scripts on install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meson: Installation of default scripts should be gated with option
3 participants