-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to set scaler and filter #893
Conversation
Removed option to explicitly force integer scaler
If we are changing this, lets do it for the filter as well. I agree that we are probably long-ish due for changing the key binds for these too to cycle instead of toggle. It's a breaking change but I don't think it's world breaking unlike if we changed what atoms used etc. |
Should I implement that change? If anything, the number of options will only increase as more upscalers come out.
I have implemented a shortcut for this already on my machine, but you do not know which one is currently selected. There is no output / overlay. We could communicate it with MangoApp.
Sure, I think the changes in this PR will not affect many people and it is fairly easy to adopt. |
Go for it :) |
- Removed options to set filters explicitly (-n, -U, -Y) - Changed scaler option from -s to -S - Reordered usage slightly
Thanks, I managed to compile this PR and I can finally play stretched CS:GO in desktop mode on my Deck without having to change the desktop resolution :) |
Compiled this PR and works well playing CSGO on my laptop. 1440x1080p on Wayland with -vulkan Did try and get it working with flatpak steam however it complained Xwayland couldn't be found (I couldn't figure it out for the life of me, maybe someone smarter will) CPU: 11th Gen Intel i7-11370H (8) @ 4.800GHz |
@Ichicoro @cigzag I'm happy it worked out for you. ;) @cigzag Regarding your issue, have a look at #848. This sounds like it matches your use case. I think you are using a hybrid gpu setup? @Joshua-Ashton I also have implemented the argument for the filters, is anything holding back this PR? |
One of my friends rage-uninstalled Linux as he wasn't able to set his shooter to a streched resolution.
Therefore I want to prevent other people from suffering that much and made the already existing option accessible.
As it was superfluous, I removed the option to explicitly force integer scaler. This might be a breaking change.
Some points to discuss:
At the moment there are multiple options that contradict each other. (-U, -Y, -n)
README.md
isn't correct about building instructions as the binary is atbuild/src/gamescope
.Is this a mistake?
Would this be useful to anybody or would explicit shortcuts make more sense?
Related: #399