Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow multiple sources in plugins #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axtloss
Copy link
Member

@axtloss axtloss commented Nov 20, 2024

Adds support for defining more than one source in the meson and make plugins as well as some improvements in systemd-sysext

@axtloss axtloss requested a review from mirkobrombin November 20, 2024 08:46
@taukakao
Copy link
Member

taukakao commented Nov 20, 2024

Having a different syntax for the sources field in just this module seems very inconsistent thus counter intuitive.

Would an "additionalSources" field or something work here? That would also not require a breaking change in the vib syntax.

@axtloss
Copy link
Member Author

axtloss commented Nov 20, 2024

Having a different syntax for the sources field in just this module seems very inconsistent thus counter intuitive.

what do you mean? that's already a thing in the shell module and this pr adds it to the rest

@taukakao
Copy link
Member

that's already a thing in the shell module and this pr adds it to the rest

I see. But should it then not also be added for the go and apt plugins for example?

@axtloss
Copy link
Member Author

axtloss commented Nov 20, 2024

apt possibly yes.
not go though, all it does is compile a binary using go and install it, any extra files couldn't even be used by the plugin, with the meson, make and shell command they can

@taukakao
Copy link
Member

Fair enough. I think it should be as consistent as possible, of course excluding plugins which it doesn't make sense for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants