-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:[#213] Rerun first setup in normal mode until all packages have been installed #226
base: main
Are you sure you want to change the base?
Conversation
Wouldn't it make more sense to let the tests be commands? things like |
Oh, I assumed that |
This does not really address my points in the comment, as there now are multiple commands without any tests, which could still cause issues when not installed properly |
Now it will use a JSON file called tests.json. The tests (and which options have to be selected for those tests) will be stored in that file. The old system did not work for a few reasons: 1. It used commands to verify that the package was installed but most package did not have binary files installed. Instead it now checks for the file being present. 2. It used to check for the commands being present during the same boot that they were installed in. Instead it now checks on the next boot. The tests run when First Setup starts and if it's the next boot the tests run to check if the files installed by the packages are present. If they are, it proceeds with the next boot. if they are not, it run the first boot again (meaning the packages are installed again)
Forgot to do that in the last commit
No description provided.