Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[#358] add custom reboot and close commands #362

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Oct 25, 2024

  • add recipe keys for reboot and close commands
  • call custom commands with subprocess instead hardcoded commands
  • add recipe keys to example

closes #358

- add recipe keys for reboot and close commands
- call custom commands with subprocess instead hardcoded commands
- add recipe keys to example
@jardon jardon marked this pull request as ready for review October 25, 2024 22:55
@jardon jardon requested a review from mirkobrombin October 25, 2024 22:56
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, in vanilla os there is no need to reboot anymore, we’ll have to update our reboot command (here or in the desktop image) to simply logout the user.

@jardon
Copy link
Member Author

jardon commented Oct 26, 2024

We use the reboot_condition set to "false" to avoid the reboot. so even with setting the recipe reboot command, it wont get triggered unless we change the reboot condition.

@jardon
Copy link
Member Author

jardon commented Oct 26, 2024

@mirkobrombin why do we layer a recipe in instead of using the one in the repo? we include that one as well as an example in the repo. the included one and the one here are the same except for the reboot condition

@jardon
Copy link
Member Author

jardon commented Oct 27, 2024

the answer is that we dont. this should be more than okay to merge as is. we could change the reboot command in our recipe to the logout command, but that doesnt do anything as our reboot condition always allows us to log out. this change is really introduced for use outside of vanilla to make our tooling more flexible.

@jardon jardon merged commit dd866df into Vanilla-OS:main Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing reboot command in the recipe
2 participants