Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-specific target gene search #341

Merged
merged 4 commits into from
Nov 18, 2024
Merged

User-specific target gene search #341

merged 4 commits into from
Nov 18, 2024

Conversation

jstone-dev
Copy link
Collaborator

Notes

  • I’ve retained the general target gene search, although we don’t currently have a use case for it.
  • I added simple test cases for user-specific target gene search. We could probably add more target-gene-related cases, but these cover the changes made here.
  • I decided to place the user-specific target gene search in a new endpoint, /me/target-genes/search, on the model of /me/score-sets/search. An alternative would be to include a "limit to current user" parameter in the search request itself. Since we don't need users to be able to search each others' data, I thought presenting this as a separate REST collection made sense. But I'm open to changing it if someone thinks otherwise.

@jstone-dev
#273 User-specific target gene search
b979370 
**Notes**
- I’ve retained the general target gene search, although we don’t currently have a use case for it.
- I’ve added simple test cases for user-specific target gene search. We could probably add more target-gene-related cases, but these cover the changes made here.
@jstone-dev
Linting and MyPy fixes
edee224
@jstone-dev jstone-dev mentioned this pull request Oct 21, 2024
Merged
@jstone-dev jstone-dev marked this pull request as ready for review October 21, 2024 21:53
bencap
bencap approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeremy, looks good

src/mavedb/lib/target_genes.py Outdated
from mavedb.models.user import User
from mavedb.view_models.search import TextSearch

VariantData = dict[str, Optional[dict[str, dict]]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be defined here for some reason I'm missing?

@bencap bencap linked an issue Oct 23, 2024 that may be closed by this pull request
Only allow users to autocomplete with their own target genes VariantEffect/mavedb-ui#273
Closed
@bencap bencap merged commit 72a36f4 into release-2024.4.2 Nov 18, 2024
5 checks passed
@bencap bencap deleted the jstone-dev/273/target-gene-autocompletion branch November 20, 2024 21:45
@bencap bencap mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencap bencap bencap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only allow users to autocomplete with their own target genes
2 participants
@jstone-dev @bencap