Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round trip experiment #27

Merged
merged 8 commits into from
Apr 6, 2024
Merged

Round trip experiment #27

merged 8 commits into from
Apr 6, 2024

Conversation

ibbem
Copy link
Collaborator

@ibbem ibbem commented Apr 6, 2024

I'm quite happy about this solution because it seems quite flexible (even though maybe a bit overkill).
Nonetheless, feel free to enhance the formatting, output, the example, etc.
Maybe it's a good idea to use a smaller example (or add a second example) because the terms get big really fast.
The last commit is optional. Just something I thought about while being sleepy :)

@pmbittner pmbittner force-pushed the round-trip-experiment branch from 91c8f47 to 4f5ee06 Compare April 6, 2024 07:03
@pmbittner
Copy link
Member

Hi @ibbem ,
thank you very much, the experiment looks really great! ❤️ I removed the last commit (starting trip at OC) and pushed it to a new branch for now. I like the idea but for the submission, we should be consistent with the paper.

The placing of commata is a bit inconsistent. Sometimes there are commas, sometimes not. Also maybe we do not have to put them on a newline. I tried to adapt it myself but I am unused to a writer monad. I will check later.

Thank you!

@pmbittner pmbittner self-requested a review April 6, 2024 07:05
@pmbittner pmbittner merged commit df65647 into develop Apr 6, 2024
1 check passed
@ibbem ibbem deleted the round-trip-experiment branch April 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants