Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sized warning #55

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Sized warning #55

merged 4 commits into from
Jul 4, 2024

Conversation

pmbittner
Copy link
Member

No description provided.

@pmbittner pmbittner requested a review from ibbem July 3, 2024 08:49
pmbittner added 2 commits July 3, 2024 13:14
We use them in a more restricted and sane way than previously reported.
To increase trust in us using sized types sanely.
This file was definitely some madness.
Fortunately, the module was not used anymore.
@pmbittner pmbittner changed the base branch from oopsla-overview to develop July 3, 2024 13:28
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pmbittner
Copy link
Member Author

I refined the text by adding your collected reasons. What do you think?

Copy link
Collaborator

@ibbem ibbem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 🥰
Good idea to add them as an exception.

@pmbittner
Copy link
Member Author

ok! Thanks!

@pmbittner pmbittner merged commit 13a249a into develop Jul 4, 2024
1 check passed
@pmbittner pmbittner deleted the sized-warning branch July 5, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants