Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [IMP] t2d: Add support for vscode with devcontainer.json #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antonag32
Copy link
Contributor

@antonag32 antonag32 commented Oct 6, 2022

Related to #158

This PR adds supports for devcontainers, a really cool option that integrates with vscode and automatically creates development containers.

If everything goes well, when you open a folder with a .devcontainer.json file vscode automatically gives you the option to reopen in a remote container. With the proposed devcontaner.json this will open a vscode instance with:

  • Three basic extensions for Odoo Development:
    • Python Extension for Inbuilt debugging (no more pdb.set_trace() 🤩 )
    • Red Hat XML to support editing XML files (views, menus, etc...)
    • Rainbow CSV to have an easier time editing ir.access.model.csv records.

More extensions can easily be added, I only use/know of those three for Odoo development.

Odoo source code is also added to extraPaths which basically means you can Ctrl + Click on something like from odoo import models and have a new tab with the source code on it. This also means that function arguments to stuff like search are suggested now based on Odoo's source code.

I am not very familiar with t2d source code so reviews are welcome since I am not sure I am placing the new feature in the correct place.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 83.33% // Head: 83.47% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (8203f99) compared to base (45f4894).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   83.33%   83.47%   +0.14%     
==========================================
  Files           7        7              
  Lines         588      593       +5     
  Branches      101      102       +1     
==========================================
+ Hits          490      495       +5     
  Misses         69       69              
  Partials       29       29              
Impacted Files Coverage Δ
src/travis2docker/travis2docker.py 86.25% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@antonag32 antonag32 changed the title Draft: [IMP] t2d: Add support for vscode with devcontainer.json Draft: [IMP] t2d: Add support for vscode with devcontainer.json #158 Oct 6, 2022
@antonag32 antonag32 changed the title Draft: [IMP] t2d: Add support for vscode with devcontainer.json #158 Draft: [IMP] t2d: Add support for vscode with devcontainer.json Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants