Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Marimorphosis to convert tuff #4448

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

PHIQW
Copy link
Contributor

@PHIQW PHIQW commented Sep 11, 2023

Fixes issue #4415
added tuff to the marimorphosis_convertable tag list
added this change to upcoming changelog

@williewillus
Copy link
Member

You should not be editing files in generated folder by hand. Edit the data generator here

https://github.com/VazkiiMods/Botania/blob/1.20.x/Xplat/src/main/java/vazkii/botania/data/BlockTagProvider.java#L193

then run ./gradlew :Fabric:runXplatDatagen

Copy link
Member

@williewillus williewillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@PHIQW
Copy link
Contributor Author

PHIQW commented Sep 17, 2023

Thanks for letting me know! Changes to the data generator added.

After reading the tag provider, Tuff should also be considered for ENDER_AIR_CONVERTABLE since deepslate is similarly convertible. If it is, I'm not sure if it should be handled here or another pull request.

@williewillus williewillus merged commit 46d6273 into VazkiiMods:1.20.x Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants