Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smelty rod improvements #4661

Draft
wants to merge 6 commits into
base: 1.20.x
Choose a base branch
from

Conversation

NEstoll
Copy link
Contributor

@NEstoll NEstoll commented May 30, 2024

Changes the Rod of the Molten Core to use punch rather than holding right click to smelt blocks. This both brings it in line with how the rod of the shifting crust works and improves its usability.

@NEstoll
Copy link
Contributor Author

NEstoll commented May 30, 2024

Furthermore, I added the ability for the rod to smelt items in inventory using mana. Mana cost is currently the same per item as it normally is per block, but that is simple to change

@TheRealWormbo TheRealWormbo marked this pull request as draft June 13, 2024 19:38
@TheRealWormbo
Copy link
Collaborator

I think the application of the block smelting effect should go back to right-click, but it can stay instant. That would also be more consistent with your proposed in-inventory smelting, which uses right-click. However, would it maybe make more sense (and be safer) that you right-click the rod item onto the stack and not vice versa?

There will also need to be some kind of replacement for the rod proficiency bonus, which before was a smelting speed increase. But we should discuss that part on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants