Fix #696 #697
Merged
Fix #696 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better fix that doesn't CME when entries with many pages are clicked too fast. Previous fix caused other buttons to still iterate after one was handled, rather than returning and just handling the last widget.
alcatrazEscapee
force-pushed
the
1.20.x
branch
from
33b3373 to
5a04005
Compare
Fix the spotless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details and reproduction steps are in the linked issue.
Description
In
mouseClicked, the boolean return is if the button should set (and clear)isFocused(). For some buttons, it makes sense that clicking them should start and keep focus but this creates undesirable situations for Patchouli's buttons, i.e. the page turn buttons. By always returningfalse, and only formouseClicked(), this prevents the button from becoming persistently focused when clicking or scrolling.Note that this still preserves tab-style operation of the gui - the focus will still be set, and be persistent while tab/enter/arrow keys are being used. It can still create "sticky-tooltip" type situations if both mouse-based and tab-based interaction are mixed.
Video of the fixed behavior (demonstrating both mouse-based interaction, and then tab-based interaction working as intended):
Minecraft.Forge_.1.20.1.-.Singleplayer.2023-11-01.21-29-14.mp4