SLURM dependency example #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 81.88% 81.90% +0.02%
==========================================
Files 13 13
Lines 806 807 +1
==========================================
+ Hits 660 661 +1
Misses 146 146
🚀 New features to boost your workflow:
|
XkunW
reviewed
May 8, 2025
| @@ -153,7 +154,7 @@ def launch( | |||
| # Display launch information | |||
| launch_formatter = LaunchResponseFormatter(model_name, launch_response.config) | |||
| if cli_kwargs.get("json_mode"): | |||
| click.echo(launch_response.config) | |||
| click.echo(json.dumps(launch_response.config)) | |||
There was a problem hiding this comment.
This change makes no difference in stdout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new example for running a downstream SLURM job that waits for a
vec-infmodel server to be ready.Changes
SLURM Dependency Example
examples/slurm_dependency/with:run_workflow.sh: launches a model server and submits a dependent jobdownstream_job.sbatch: SLURM job script for the downstream taskrun_downstream.py: waits for readiness and sends an OpenAI-style requestREADME.md: instructions for using the exampleexamples/README.mdto link to the new example