Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to ExComm materials to info.html #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethanmann
Copy link
Contributor

Closes #207

A private Google folder link for ExComm should be added to secrets.py for this commit to work.

For testing purposes, you can add this block to default_secrets.py:

LINKS = {
    'ExComm_Meeting_Minutes':'https://www.google.com',
    'ExComm_Materials':'https://www.caltech.edu'
}

The is_excomm db attribute could be used to show/hide the ExComm Materials on the info page (I left a TODO for this).

@@ -17,6 +17,7 @@ def home():
@login_required()
def show_info():
"""Shows info page on door combos, printers, etc."""
# TODO - if desired, add excomm flag to show/hide ExComm Materials link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This todo should be implemented before the excomm link is added to the website, so that the link is only accessible by excomm members. Could be accomplished as the comment suggests by showing/hiding the link based on whether the logged in user is part of excomm. Or, could create a separate url path to this page for excomm members that includes the link. Either way would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to ExComm folder
2 participants