Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Artisan's publish features to make copying migrations an easier process. #174

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sammarks
Copy link

Rather than copying and pasting the migration file (and therefore having to worry about class names clashing), I updated the package to include a service provider that registers the migration as a publishable asset and updated the readme to include instructions on how to register the service provider and publish the migration files.

I hate to introduce more steps into the installation process of the package, but most other Laravel packages have a service provider so it's almost an expectation from me that when I'm installing a package, I'm going to need to configure a service provider. I like to consider it forward thinking, because one day this package might need to utilize a service provider, and it's better to tell them to configure the service provider now rather than in the future.

I'd also like to emphasize that if users opt not to use the service provider, it won't break the functionality of the package. Therefore those updating to the latest code won't need to figure out why their site has stopped working (and also negating the need for a major version bump).

@duellsy
Copy link
Member

duellsy commented Oct 19, 2015

Can you confirm that this works with L4?

@sammarks
Copy link
Author

Ah, my mistake. I didn't know we were maintaining Laravel 4 support in this branch. Might I suggest creating a Laravel 5 branch for future Laravel 5 development? The other Laravel packages I've seen have adopted this strategy. That way we can take advantage of the features in Laravel 5 without leaving Laravel 4 behind.

@yahya-uddin
Copy link

Totally agree with @sammarks with moving forward with Laravel 5 on a separate branch!

@stierler stierler added this to the v2.0.0 milestone Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants