Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured for psr-4 and composer. #313

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

tarekadam
Copy link

Hey, moved some files and tweaked composer.json for:

  • psr-4 (everything in src should be part of the namespace)
  • composer.json now handles namespace, auto-loader, and laravel service provider
  • service provider handles php artisan migrate

@tarekadam
Copy link
Author

Oh shit - I totally forgot to say thanks sharing!!

# Conflicts:
#	composer.json
#	readme.md
* 'master' of github.com:dakshhmehta/revisionable:
  AutoAccept added for revision creations enabled
  Rollback code for autoAccept
  Rollback some error
  if its new record, then its probably we don't want to store it
  Moving code from one method to other
  Not null should not be part of the revision
  Fix the code to work for first time record creation
  Fixed revision issue while creation for autoAccept
  Added autoAccept parameter and revision limit by key
@rickmills
Copy link
Contributor

Sadly it looks like the package author has abandoned it without adding a note to the package to let people know. Not sure this'll end up being merged so may be better to fork?

@stierler
Copy link
Collaborator

stierler commented Sep 24, 2018

@rickmills @tarekadam I will begin/resume maintaining this, although may end up moving the repository/namespace for a larger upgrade.

I have already begun taking some of these PR's and pushing into a v2, and also begin to sunset support for older Laravel versions on v2 and onward 🙏

(Edit: And thank you for the contribution! I've skimmed over it once I realized this package needed some love again, but will dive into further soon!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants