Allow to get responsible when user is soft deleted #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a package that modify the users to allow to soft delete them.
When a user is soft deleted, the method
userResponsible
will returnnull
, but the user is still in the database and is responsible for the revision. This can cause errors like "cannot get property ...... on null".I've made my own
Revision
class to fix this, but I think this must be included by default because the user is responsible and must be loaded, deleted or not.The fix is very simple, I just added
withTrashed
when getting the user.