Use a morpahble for user resolving instead of static config resolving. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 Years and still not approved?!! |
|
@wajdijurry laravel-auditing is a much better alternative, this one seems to be abandoned at this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently developing an app with multiple auth providers.
Since revisionable uses a static provider set in config, I'm getting the wrong type of users.
I changed the user field into a morphable one so, the model can be created without the need of a resolver.
This adds a simple way of supporting multiple auth providers without breaking any installations.
I keep the original userResponsible() so it does not break history revisions which got created before the update.