Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact form footer update #461

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Contact form footer update #461

wants to merge 7 commits into from

Conversation

jeromehardaway
Copy link
Contributor

@jeromehardaway jeromehardaway commented May 19, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 9180a0e

Summary

🆙🛠️📝

This pull request updates the contact form in the Footer component, the Node version in the .nvmrc file, and the engines field in the package.json file. These changes improve the contact form functionality, ensure Node version consistency, and allow Node version flexibility.

To keep up with Node's latest version
The .nvmrc file had a revision
And the package.json
Used a range, not a ton
For the node engine's decision

Walkthrough

  • Update Node version to 16 for consistency and flexibility (link, link)
  • Replace ContactForm component with iframe element from Monday.com in Footer component (link, link)

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vets-who-code-app ✅ Ready (Inspect) Visit Preview May 19, 2023 0:20am

andrew-t-james
andrew-t-james reviewed May 19, 2023
View reviewed changes
Copy link
Member

@andrew-t-james andrew-t-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though the goal was to drop this change?

@jeromehardaway
Copy link
Contributor Author

@andrew-t-james yeah,Trying to work off his branch but its being wonky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-t-james andrew-t-james andrew-t-james left review comments

@mrbernnz mrbernnz Awaiting requested review from mrbernnz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromehardaway @andrew-t-james @axecopfire