Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ViaVersion v5.0 #1

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Update for ViaVersion v5.0 #1

merged 4 commits into from
Jun 19, 2024

Conversation

calcastor
Copy link
Contributor

This updates ViaChatFixer for ViaVersion 5.0

I have not checked if this works on Sponge given changes relative to Sponge in ViaVersion.

@MrMicky-FR
Copy link
Member

MrMicky-FR commented Jun 17, 2024

Hi, thanks for your pull request, I didn't think ViaChatFixer was still in use after all this time!

Looks good, just about the Sponge version, as ViaVersion v5 only supports SpongeAPI v8, which is Minecraft 1.15, unless I miss something (I'm definitely not a Sponge expert!), old Sponge servers can't use ViaVersion v5, so Sponge support could now be removed?

@calcastor
Copy link
Contributor Author

Hi, thanks for your pull request, I didn't think ViaChatFixer was still in use after all this time!

Looks good, just about the Sponge version, as ViaVersion v5 only supports SpongeAPI v8, which is Minecraft 1.15, unless I miss something (I'm definitely not a Sponge expert!), old Sponge servers can't use ViaVersion v5, so Sponge support could now be removed?

I know very little about Sponge either but this sounds correct. I've removed Sponge support in the most recent commit.

Only thing I'm not sure about is how best to determine that the appropriate version of ViaVersion is loaded. This obviously won't work with v4.x but it will definitely try to load with it.

@MrMicky-FR MrMicky-FR merged commit 9ce9dd9 into ViaVersionAddons:master Jun 19, 2024
2 checks passed
@MrMicky-FR
Copy link
Member

Great thank you 🚀 I also removed the various modules that were no longer needed with the removal of Sponge and changed the output to Java 8 again (ViaVersion still offers a Java 8 build and no recent Java features were used)

Only thing I'm not sure about is how best to determine that the appropriate version of ViaVersion is loaded. This obviously won't work with v4.x but it will definitely try to load with it.

Checking for the com.viaversion.viaversion.api.type.Types class, introduced with ViaVersion 5 seems to be a good solution 😃

@calcastor calcastor deleted the 5.0 branch June 20, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants