Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favorite movies sections #107

Merged
merged 46 commits into from
Dec 28, 2023
Merged

Added favorite movies sections #107

merged 46 commits into from
Dec 28, 2023

Conversation

VictorKabata
Copy link
Owner

Description

  • Added caching layer to save favourite movie details

Issue

N/A

Changes Made

  • Added sqlDelight lib
  • Added caching of movie details to FavouriteMovieTable

Screenshots / GIFs

Checklist

  • I have tested the changes on both Android and iOS platforms.
  • I have written unit tests for the new code (if applicable).
  • I have updated the project's documentation (if necessary).
  • I have checked for any potential code duplications and removed them.
  • I have run the Kotlin/Compose Multiplatform Gradle tasks and verified that they complete successfully.
  • I have considered the impact of these changes on the existing codebase.

Additional Notes

  • Need to add periodic sync of movies cached in FavouriteMovies table

@VictorKabata VictorKabata added the enhancement New feature or request label Dec 28, 2023
@VictorKabata VictorKabata merged commit 6145748 into develop Dec 28, 2023
1 check passed
@VictorKabata VictorKabata deleted the caching-sqldeight branch December 28, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant