Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labels merging #1287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix labels merging #1287

wants to merge 1 commit into from
+15 −15

Conversation

dmitriikazanin
Copy link

swapped labels maps in merge function

f41gh7
f41gh7 requested changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add motivation for this change?

Currently, if any of podMetadata labels will override value of selectorLabels, it may completely break operator logic and make it dysfunctional.

@dmitriikazanin dmitriikazanin mentioned this pull request Mar 20, 2025
Open
@dmitriikazanin
Copy link
Author

At least it makes sense provide for developers an ability to set suitable value for label "app.kubernetes.io/component" (vmagent, vmauth etc).
Of course you can provide more suitable solution as I don't know all specific details of the operator.
Anyway it looks odd to set only hardcoded "monitoring" value for all components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 requested changes

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

@AndrewChubatiuk AndrewChubatiuk Awaiting requested review from AndrewChubatiuk AndrewChubatiuk is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriikazanin @f41gh7