Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev process #104

Merged
merged 2 commits into from
Nov 14, 2024
Merged

update dev process #104

merged 2 commits into from
Nov 14, 2024

Conversation

dmitryk-dk
Copy link
Contributor

@dmitryk-dk dmitryk-dk commented Nov 13, 2024

Starting from Grafana v10.4.0 it tries to check the folder inside the defined plugin folder.
If we set
plugins = /Users/path/victorialogs-datasource Grafana tries to check source plugins in the src folder and shows the error that the backend file can be found
But if we declare the path like
plugins = /Users/path/plugins/victorialogs-datasource (we create a folder above our plugin) it works correctly.

Also started from Grafana v10.4.0 when we started it and defined the plugin folder it added its own plugin named
grafana-lokiexplore-app

Those changes are compatible with the previous version of Grafana

@dmitryk-dk dmitryk-dk marked this pull request as ready for review November 13, 2024 08:35
Copy link
Contributor

@Loori-R Loori-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit bda264e into main Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants