Fixes and small improvements in menu items commands #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barijaona
changed the title
When used on main tab, Command-Y keyboard combination toggled the current article read/unread (with the same effect as Command-U). As this keyboard combination is intended to switch to articles tab, it should have no effect when used on the main tab.
- Change ActivityViewer class to be NSWindow (instead of NSPanel) - Modify "Activity Window" menu item to not behave anymore as a toggle This makes user interface more consistent, by having similar behavior for Activity and Download windows: they are both listed at the bottom of the "Window" menu when they are visible.
- There is no rationale for the "Next Unread" menu item being in the "View" menu: move it to "Article" menu. - The "Article List" menu item (which activates the main tab) fits better in the "Window" menu, alongside "Previous Tab" and "Next Tab". - Rearrange menu items related to browsing in the "View" menu in a layout similar to the one used in Apple's Safari Keyboard shortcuts remain unchanged, so I don't expect these changes to cause inconvenience to long time users.
Eitot
reviewed
Jan 7, 2024
Change in Interface Builder the full-screen configuration to "auxiliary window" and the spaces configuration to "move to active space". Full-screen mode is not necessary for this window, which should stay together with the main window.
Same behavior should probably apply to Downloads and InfoWindow. |
Same behavior than Activity window
Eitot
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem with Command-Y shortcut
Fix greyed out "Reload Page" command
Simplify behavior of "Activity window" menu item
Rearrange some items present in the "View" menu