Improve folder's cache error handling #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh64x2
requested changes
Jun 19, 2024
Vienna/Sources/Models/Folder.m
Outdated
| /* getArticlesAndCache | ||
| * Returns articles and store in cache if possible | ||
| */ | ||
| -(NSArray<Article *> *)getArticlesAndCache |
There was a problem hiding this comment.
I think this should be split in to two functions:
- return the array of Articles (if there isn't already a function)
- cache the articles
The name getArticlesAndCache is a bit confusing, and I'd expect two objects returned: 1) array of articles, 2) a cache object
There was a problem hiding this comment.
The cache object itself is self.cache
It's just a byproduct of the process that gets the content of the articles.
Updated version clarifies this.
Fix articles not being displayed when, for some reason, error messages "Bug retrieving for cache in folder …" appear in logs.
barijaona
force-pushed
the
cacheManagement
branch
from
90da870 to
927fc2c
Compare
josh64x2
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix articles not being displayed when, for some reason, error messages "Bug retrieving for cache in folder …" appear in logs.