Improvements to folders tree #1783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't proceed to folder move if Database's -setParent:forFolder: or -setNextSibling:folderFromID:forFolder: return NO. Adapt accordingly the insertion into undoArray.
Remove extraneous spaces while keeping the tab based spacing in order to preserve the legibility of git history. Other slight changes to improve legibility.
Having feed sorted by names rather than by folder ID would be more user friendly. Follow-up of PR ViennaRSS#1754, working on issue ViennaRSS#1768
This was
linked to
issues
Jul 29, 2024
When ‑loadTree:rootNode: returns NO, recover group folders as well as RSS and OpenReader folders by reattaching them under the root folder. A user reported in issue ViennaRSS#1784 losing group folders which just went invisible but were still present in database.
Might help understand origin of the issue. Occurence of problems can be traced back with the following command in Terminal: log show --predicate " process == 'Vienna' && eventMessage contains 'Fixing' " --last 96h
Eitot
approved these changes
Aug 5, 2024
|
Not yet mature enough… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on PR #1754 (Improve handling of FoldersTree manual sort issues)
Should help with sort order issues #1768 and #1779