Add error for no constant

VincentLanglet · Jul 23, 2024 · affdc25 · affdc25
1 parent 9509feb
commit affdc25
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/src/Rules/Node/ValidConstantFunctionRule.php b/src/Rules/Node/ValidConstantFunctionRule.php
@@ -32,6 +32,12 @@ public function enterNode(Node $node, Environment $env): Node
             // Try for named parameters
             $argument = $arguments->getNode('constant');
         } else {
+            $this->addError(
+                'The first param of the function "constant()" is required.',
+                $node,
+                'NoConstant'
+            );
+
             return $node;
         }
         if (!$argument instanceof ConstantExpression) {

diff --git a/tests/Rules/Node/ValidConstantFunction/ValidConstantFunctionRuleTest.php b/tests/Rules/Node/ValidConstantFunction/ValidConstantFunctionRuleTest.php
@@ -22,6 +22,7 @@ public function testRule(): void
             'ValidConstantFunction.ClassConstant:20' => 'You cannot use the function "constant()" to resolve class names.',
             'ValidConstantFunction.ClassConstant:21' => 'You cannot use the function "constant()" to resolve class names.',
             'ValidConstantFunction.StringConstant:22' => 'The first param of the function "constant()" must be a string.',
+            'ValidConstantFunction.NoConstant:24' => 'The first param of the function "constant()" is required.',
         ]);
     }
 }
diff --git a/tests/Rules/Node/ValidConstantFunction/ValidConstantFunctionRuleTest.twig b/tests/Rules/Node/ValidConstantFunction/ValidConstantFunctionRuleTest.twig
@@ -21,5 +21,6 @@
     {{ constant(constant='ThisDoesNotExist::CLASS') }}
     {{ constant(constant=1) }}
 
+    {{ constant() }}
     {{ notConstant('ThisDoesNotExist::class') }}
 {% endblock %}