Add test for ValidConstantFunctionRule

[VincentLanglet]

No description provided.

[VincentLanglet]

@ruudk you wrote in your initial PR bffffcb

        $constant = $argument->getAttribute('value');
        if (!\is_string($constant)) {
            return $node;
        }

Is there valid case when the value is not a string or should we display an error for this case ?

[ruudk]

I did this because the return type was mixed according to psalm or PHPStan. Shouldn't be the case I think.

[ruudk]

So maybe beter to report an error in that case.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5846e15) to head (1ddb1c8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@              Coverage Diff              @@
##               main      #282      +/-   ##
=============================================
+ Coverage     99.91%   100.00%   +0.08%     
- Complexity      726       729       +3     
=============================================
  Files            65        65              
  Lines          2259      2266       +7     
=============================================
+ Hits           2257      2266       +9     
+ Misses            2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[VincentLanglet]

I'll take any suggestion here @ruudk but I'd like to avoid a too long error message.

So far I always had short message like "Variable should be called foo" or "Expected 2 spaces, found 1". This gave report with all the error messages written on single line every time and I'm not happy with the fact that this error would be certainly written with multiples lines.

Maybe letter something like an additional help text could be written, but so far I'd like a short message.
I try 'You cannot use the function "constant()" to resolve class names.' but take any suggestion

[ruudk]

Fine. This is coming directly from https://github.com/twigphp/Twig/blob/1377f2da4efa020d2ad9b8fb8b722d688ab297ad/src/Extension/CoreExtension.php#L1474