Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements StopSound for AnimTypes and VoxelAnimTypes. #546

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Sep 9, 2021

Closes #474, Closes #475

This pull request implements the StopSound key from Red Alert 2 for both AnimTypes and VoxelAnimTypes.

AnimType or VoxelAnimType section.
StopSound=<VocType> - The sound effect to play when this animimation has finished/been removed. Defualts to <none>.

@CCHyper CCHyper added the new-feature New feature or request. label Sep 9, 2021
@CCHyper CCHyper added this to the RA2/YR Features milestone Sep 9, 2021
@CCHyper CCHyper requested a review from a team September 9, 2021 18:06
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from b000bdc to 3eb9620 Compare September 15, 2021 21:38
@tomsons26
Copy link
Contributor

Looking at YR it doesn't actually implement it for Voxel Anims, so this needs verifying there aren't any issues or it works at all even.
Anim code matches YR so thats good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature] Add StopSound for AnimTypes. [New Feature] Add StopSound for VoxelAnimTypes.
2 participants