-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements StopSound
for AnimTypes and VoxelAnimTypes.
#546
Open
CCHyper
wants to merge
2
commits into
Vinifera-Developers:develop
Choose a base branch
from
CCHyper:ra2-stopsound
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+205
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request. These links are also updated when the pull request is pushed to. |
CCHyper
force-pushed
the
develop
branch
2 times, most recently
from
September 15, 2021 21:38
b000bdc
to
3eb9620
Compare
Looking at YR it doesn't actually implement it for Voxel Anims, so this needs verifying there aren't any issues or it works at all even. |
CCHyper
force-pushed
the
develop
branch
2 times, most recently
from
October 15, 2021 21:02
29e7495
to
530c32e
Compare
CCHyper
force-pushed
the
ra2-stopsound
branch
from
October 15, 2021 21:32
938cd4f
to
2b5a79c
Compare
CCHyper
force-pushed
the
develop
branch
3 times, most recently
from
October 16, 2021 21:59
58dc156
to
1b504cc
Compare
CCHyper
force-pushed
the
ra2-stopsound
branch
from
October 17, 2021 11:44
2b5a79c
to
b183014
Compare
CCHyper
force-pushed
the
ra2-stopsound
branch
from
October 24, 2021 16:36
b183014
to
95a07c3
Compare
CCHyper
force-pushed
the
develop
branch
2 times, most recently
from
January 21, 2022 22:45
eb03022
to
8ed42ec
Compare
CCHyper
force-pushed
the
develop
branch
13 times, most recently
from
February 24, 2022 01:05
5e9bf4a
to
ee4b285
Compare
CCHyper
force-pushed
the
ra2-stopsound
branch
from
September 22, 2022 14:23
9c87b24
to
6e44adb
Compare
CCHyper
force-pushed
the
develop
branch
2 times, most recently
from
November 9, 2022 14:53
07c9446
to
379970b
Compare
CCHyper
force-pushed
the
develop
branch
3 times, most recently
from
December 22, 2022 08:32
48cd2ea
to
b789478
Compare
CCHyper
force-pushed
the
develop
branch
3 times, most recently
from
February 24, 2023 11:01
d649039
to
5a6cb19
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
September 26, 2024 13:00
65abfa3
to
5be9542
Compare
ZivDero
force-pushed
the
develop
branch
5 times, most recently
from
October 17, 2024 22:42
a307ea7
to
735e008
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
October 22, 2024 15:52
f40cd5a
to
ce12b49
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
November 27, 2024 12:27
c3e7349
to
0a8e674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474, Closes #475
This pull request implements the
StopSound
key from Red Alert 2 for both AnimTypes and VoxelAnimTypes.AnimType or VoxelAnimType section.
StopSound=<VocType>
- The sound effect to play when this animimation has finished/been removed. Defualts to<none>
.