PR3: Adding abstract class corresponding to OpenCvVisualizer3D and making other relevant changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarika93
commented
Dec 12, 2024
| @@ -51,7 +51,7 @@ class MeshOptimization { | |||
| MeshOptimization(const MeshOptimizerType& solver_type, | |||
| const MeshColorType& mesh_color_type, | |||
| Camera::ConstPtr camera, | |||
| OpenCvVisualizer3D::Ptr visualizer = nullptr); | |||
| std::shared_ptr<VIO::BaseOpenCvVisualizer3D> visualizer = nullptr); | |||
There was a problem hiding this comment.
Not sure about format of the this, per Google C++ styleguide.
sarika93
commented
Dec 12, 2024
| @@ -50,7 +50,7 @@ constexpr float MeshOptimization::kMaxZ; | |||
| MeshOptimization::MeshOptimization(const MeshOptimizerType& solver_type, | |||
| const MeshColorType& mesh_color_type, | |||
| Camera::ConstPtr camera, | |||
| OpenCvVisualizer3D::Ptr visualizer) | |||
| std::shared_ptr<VIO::BaseOpenCvVisualizer3D> visualizer) | |||
There was a problem hiding this comment.
Not sure about format of the this, per Google C++ styleguide.
sarika93
requested review from
vpradeep07 and
shiv1994
and removed request for
vpradeep07,
shiv1994 and
enrique-ramkissoon
sarika93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
The follow up PR will have all other abstract classes, but submitting this one first to make sure the format of changes are reasonable.