Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #105added gap between our goals and footer section #106

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Vinayyy19
Copy link
Contributor

Pull Request Template

Description

To add a gap between the "Our Goals" section and the footer section, I have added a line in CSS that creates a gap between the two sections.

Related Issue

Fixes #105

Changes Made

Given a margin from the top of the footer to increase the gap of 100px.

Screenshots

image

Checklist

  • I have read the contributing guidelines.
  • I have tested my changes.
  • My code follows the code style of this project.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a pull request @Vinayyy19. We'll will review it as soon as possible 🙌❤️

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use static values like px

@Vinayyy19
Copy link
Contributor Author

hey @Virtual4087 i have replaced px with rem could you please check it out

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Virtual4087 Virtual4087 merged commit 22a851f into Virtual4087:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the gap between Our goals and footer section
2 participants