Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]:Removed popup when Donate is clicked #112

Closed

Conversation

dexterousdhruv
Copy link

Prevents the modal from popping up on clicking Donate button in navbar.

Closes #109

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a pull request @dexterousdhruv. We'll will review it as soon as possible 🙌❤️

@dexterousdhruv dexterousdhruv changed the title [FIX]:Removed popup when Donate is clicked [fix]:Removed popup when Donate is clicked Oct 9, 2024
Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hye @dexterousdhruv the popup is still there. Kindly check the results in your local environment before submitting a pr.

@dexterousdhruv
Copy link
Author

@Virtual4087 Ah! My bad. Done the changes now, kindly have a look.

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this doesn't work as expected either. You could have just removed the "showPopupButton" from the class or only removed the "data-popup-trigger" for it to work. I think changing the JS was unnecessary.

Unfortunately, someone already submitted a valid PR before you so I'll have to merge that. Feel free to create new issues and I'll assign them to you.

@Virtual4087 Virtual4087 closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Donate Us" button in the Navbar
2 participants