Adding sliding effect in hamburger icon and made responsive for phone screen #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening a pull request @DHRUVKAPOOR07. We will review it as soon as possible 🙌❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Virtual4087 ,
To fix the white line issue, I added overflow-x: hidden to the html and body to prevent horizontal scrolling caused by elements exceeding the viewport width. I applied box-sizing: border-box globally to ensure padding and borders are included in the total element width, avoiding overflow. Lastly, I set the .banner width to 100vw to ensure it fully fits the viewport without extending beyond it and add a sliding effect in navbar when click on hamburger icon