-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PythonMethodHeuristic #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/test/kotlin/org/virtuslab/bazelsteward/app/VersionReplacementHeuristicTest.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonMethodHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonMethodHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
lukaszwawrzyk
requested changes
Feb 20, 2023
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/WholeLibraryHeuristic.kt
Outdated
Show resolved
Hide resolved
kinds/maven/src/main/kotlin/org/virtuslab/bazelsteward/maven/MavenCoordinates.kt
Outdated
Show resolved
Hide resolved
kinds/bazel/version/src/main/kotlin/org/virtuslab/bazelsteward/bazel/version/BazelUpdater.kt
Outdated
Show resolved
Hide resolved
lukaszwawrzyk
requested changes
Feb 21, 2023
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/WholeLibraryHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/WholeLibraryHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
kinds/maven/src/main/kotlin/org/virtuslab/bazelsteward/maven/MavenCoordinates.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/WholeLibraryHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/WholeLibraryHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/VersionReplacementHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/PythonFunctionCallHeuristic.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/virtuslab/bazelsteward/core/replacement/VersionReplacementHeuristic.kt
Outdated
Show resolved
Hide resolved
Try in PythonMethodHeuristic Logic Fixed PythonMethodHeuristic
lukaszwawrzyk
force-pushed
the
python
branch
from
February 22, 2023 11:48
dbf1337
to
10370dd
Compare
lukaszwawrzyk
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PythonMethodHeuristic and associatedStrings to Maven Coordinates without scala version in compliance with #95