Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource references #317

Closed
wants to merge 2 commits into from
Closed

Add resource references #317

wants to merge 2 commits into from

Conversation

pawelprazak
Copy link
Contributor

Fixes #144

@pawelprazak pawelprazak added impact/broken Something that is difficult or impossible for some people to use kind/missing We are missing a part of functionality compared to upstream area/codegen Schema to code generator area/core The SDK's core code labels Dec 1, 2023
@pawelprazak pawelprazak added this to the 0.2.0 milestone Dec 1, 2023
@pawelprazak pawelprazak requested a review from lbialy December 1, 2023 14:03
@pawelprazak pawelprazak mentioned this pull request Dec 1, 2023
Closed
@pawelprazak pawelprazak added the do-not-merge DO NOT UNDER ANY CONDITION MERGE THIS label Dec 1, 2023
@pawelprazak pawelprazak mentioned this pull request Dec 4, 2023
Merged
@lbialy
Copy link
Collaborator

lbialy commented Dec 14, 2023

is this still necessary?

@pawelprazak
Copy link
Contributor Author

Need to double-check, it add the union with resource, e.g. String | besom.api.aws.iam.Role

@pawelprazak
Copy link
Contributor Author

Incorporated into #332

@pawelprazak pawelprazak deleted the pprazak/144-add-resource-refs branch December 14, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbialy lbialy Awaiting requested review from lbialy

Assignees
No one assigned
Labels
area/codegen Schema to code generator area/core The SDK's core code do-not-merge DO NOT UNDER ANY CONDITION MERGE THIS impact/broken Something that is difficult or impossible for some people to use kind/missing We are missing a part of functionality compared to upstream
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Refer to other resources by reference instead of ID
2 participants
@pawelprazak @lbialy