Add resource method generation to codegen #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
added
impact/broken
lbialy
requested changes
Dec 3, 2023
| token: FunctionToken, | ||
| args: A, | ||
| resource: T | ||
| )(using Context): Output[R] |
There was a problem hiding this comment.
not exactly correct, missing CallOptions
There was a problem hiding this comment.
but we can disregard that for now
There was a problem hiding this comment.
yes, you are correct, it's a stub only
| "azure-quickstart-acr-geo-replication", | ||
| "aws-quickstart-redshift", | ||
| "nxos" | ||
| ) |
There was a problem hiding this comment.
the packages that are not downloading schemas properly
lbialy
approved these changes
Dec 4, 2023
pawelprazak
force-pushed
the
pprazak/283-add-methods
branch
from
786e9c3 to
3cb41e0
Compare
pawelprazak
force-pushed
the
pprazak/283-add-methods
branch
2 times, most recently
from
96c8268 to
be20140
Compare
pawelprazak
force-pushed
the
pprazak/283-add-methods
branch
from
be20140 to
f6ede28
Compare
pawelprazak
force-pushed
the
pprazak/283-add-methods
branch
from
f6ede28 to
0e8b683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283