Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #196

Merged
merged 105 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
b5696a2
Merge pull request #124 from africanmathsinitiative/master
MeSophie Nov 2, 2023
9d5d47c
minor change
MeSophie Nov 2, 2023
f6c7814
minor change
MeSophie Nov 2, 2023
1cfe2ed
improved colour tb
MeSophie Nov 2, 2023
6da77a3
minor change
MeSophie Nov 2, 2023
c2c4a29
minor change
MeSophie Nov 2, 2023
febd01c
Merge pull request #458 from africanmathsinitiative/master
conlooptechnologies Nov 5, 2023
33c361e
Created the Emmeans Keyboard
derekagorhom Nov 7, 2023
fe8ddf2
Merge pull request #461 from africanmathsinitiative/master
conlooptechnologies Nov 7, 2023
b11d40f
Changing btn design names for the keys
derekagorhom Nov 7, 2023
fc1d906
Added the function for the emmeans keyboards
derekagorhom Nov 8, 2023
cd926c0
More changes
derekagorhom Nov 9, 2023
3f63c7f
Fixing issues with graphic images not appearing for the emmeans kkeyb…
derekagorhom Nov 9, 2023
0a78ebf
Fixes bug in adding of columns
conlooptechnologies Nov 10, 2023
63e2196
Added quotes and curly line key to emmeans keyboard
derekagorhom Nov 10, 2023
17ea2f6
minor code change
Vitalis95 Nov 10, 2023
bfc4740
implementing the try control for the Use Model keyboard
derekagorhom Nov 10, 2023
67e5a9d
Update data_object_R6.R
lilyclements Nov 10, 2023
6c9a15c
Merge pull request #52 from lilyclements/two_variable_repo
derekagorhom Nov 10, 2023
fcb01b1
Set the focus to return to the first receiver always when re-opening …
N-thony Nov 11, 2023
705d636
added different options to apply the column selection
N-thony Nov 11, 2023
821ba6c
fixed developer error
N-thony Nov 11, 2023
3d03a5a
changed radio buttons to checkboxes
N-thony Nov 13, 2023
0f123b5
bug fixes
N-thony Nov 13, 2023
523f0ea
minor change
N-thony Nov 13, 2023
00bf4e9
reverted the R code
N-thony Nov 13, 2023
0ad2b56
disable dialogue checkbox
N-thony Nov 13, 2023
8ac28bb
Design change
MeSophie Nov 13, 2023
2097bb5
Change made on colour tab in plot option
MeSophie Nov 15, 2023
b999d3e
code improvement and fixed tab orders in dlgDescribeTwoVariables
N-thony Nov 15, 2023
cab5f1a
added save radio button and design changes
N-thony Nov 16, 2023
b555cbe
made column selection available to dialogues,
N-thony Nov 16, 2023
8f21fef
enabled dataframe checkbox
N-thony Nov 16, 2023
1c5b8b6
fixed the dialogs option
N-thony Nov 16, 2023
2b2cf21
Merge pull request #463 from africanmathsinitiative/master
conlooptechnologies Nov 16, 2023
dd86f6f
fixed metadata column selection
N-thony Nov 16, 2023
c457f66
minor change in getting the columns
N-thony Nov 16, 2023
f67200a
fixed formatting
N-thony Nov 16, 2023
dbb0a3c
Merge pull request #134 from africanmathsinitiative/master
MeSophie Nov 17, 2023
10059b6
Fixed minor issue in General Graph Dialog
MeSophie Nov 17, 2023
22b7f96
Change made
MeSophie Nov 17, 2023
07b7d18
Merge pull request #465 from africanmathsinitiative/master
conlooptechnologies Nov 17, 2023
a3aaa71
minor code change
Vitalis95 Nov 20, 2023
395b21b
Tidying up the Four variable model
derekagorhom Nov 20, 2023
9c5713c
Merge pull request #8653 from MeSophie/GeneralGraphicsissue8651
N-thony Nov 21, 2023
14ffb31
null checking in sdgplots
conlooptechnologies Nov 23, 2023
12d23ff
more null checks
conlooptechnologies Nov 23, 2023
828115c
Added AOV and tidy 4-variable modelling
derekagorhom Nov 24, 2023
27bab42
added partially labelled
N-thony Nov 24, 2023
1c1f855
improved the R code
N-thony Nov 25, 2023
6d46606
Code changes
derekagorhom Nov 27, 2023
b998a8e
Merge pull request #138 from africanmathsinitiative/master
MeSophie Nov 27, 2023
63b2328
Climatic_mnu
Fidel365 Nov 27, 2023
7d04ba6
Fixed issue on Histogram and Boxplot dialog
MeSophie Nov 27, 2023
95114fc
minor change
MeSophie Nov 27, 2023
584052b
Merge pull request #8669 from Fidel365/Tidy_data
N-thony Nov 28, 2023
cc66e6b
Merge pull request #8670 from MeSophie/HistoplotIssue8659
N-thony Nov 28, 2023
7df8a99
Merge pull request #8641 from Patowhiz/add_columns
N-thony Nov 28, 2023
da2a2d9
Merge pull request #8639 from derekagorhom/Added_New_Emmeans_Keyboard
N-thony Nov 28, 2023
d650032
Merge pull request #8655 from Vitalis95/Random_splitdlg
N-thony Nov 28, 2023
f4d1f70
Merge pull request #8643 from Vitalis95/Infill_missing_date
N-thony Nov 28, 2023
16fc892
Added AOV function into Two and Three Variable Modelling
derekagorhom Nov 28, 2023
7f1f37d
minor code change
N-thony Nov 28, 2023
83cfc02
Added the AOV function to the General model and fit mode dialogues
derekagorhom Nov 28, 2023
682b42e
minor code change
N-thony Nov 28, 2023
554c286
minor change "labels" to labels_lable
N-thony Nov 28, 2023
05721c8
minor addition
N-thony Nov 28, 2023
bcb05d2
Fixed odd bug in the fit Model
derekagorhom Nov 29, 2023
82c01cc
minor change
N-thony Nov 29, 2023
a4e0206
added todo comment
N-thony Nov 29, 2023
8da7529
Update instat/Model/DataFrame/clsDataFramePage.vb
N-thony Nov 29, 2023
c0a3ef0
Update instat/clsRLink.vb
N-thony Nov 29, 2023
5704345
Update instat/Model/DataFrame/clsColumnMetaData.vb
N-thony Nov 29, 2023
2e94d1d
minor change
N-thony Nov 29, 2023
0b4f8bb
Merge pull request #140 from africanmathsinitiative/master
MeSophie Nov 30, 2023
3dac1ba
Change made on Climatic>Describe menu
MeSophie Nov 30, 2023
f90116c
minor change
MeSophie Dec 1, 2023
ce8d4b6
Merge pull request #143 from africanmathsinitiative/master
MeSophie Dec 1, 2023
b9dd169
minor change
MeSophie Dec 1, 2023
1a7b823
minor change
MeSophie Dec 1, 2023
1adff78
Merge pull request #8648 from N-thony/improveColumnSelection
conlooptechnologies Dec 1, 2023
297e006
Added back version number
N-thony Dec 4, 2023
cd0acf3
minor change
MeSophie Dec 4, 2023
5481a0a
Code changes
derekagorhom Dec 4, 2023
935d3a5
Merge pull request #8678 from N-thony/version_number
conlooptechnologies Dec 4, 2023
e63337d
minor change
MeSophie Dec 5, 2023
efe2aab
Merge pull request #8613 from MeSophie/Sdgplotcolour
N-thony Dec 5, 2023
188278d
Merge pull request #145 from africanmathsinitiative/master
MeSophie Dec 5, 2023
856f53d
minor change
MeSophie Dec 5, 2023
5e7bc24
Merge pull request #8674 from MeSophie/ClimaticDescribe8660
N-thony Dec 6, 2023
66ec183
minor code adjustement
N-thony Dec 6, 2023
c047ac0
Merge pull request #149 from africanmathsinitiative/master
MeSophie Dec 6, 2023
c8f7a2d
minor Change
MeSophie Dec 6, 2023
13b8b5f
minor change
MeSophie Dec 6, 2023
003c3a0
minor change
MeSophie Dec 6, 2023
72d5f5b
minor change
MeSophie Dec 6, 2023
0a49f9d
Added an empty dialog
MeSophie Dec 6, 2023
9f7a553
Merge pull request #8679 from MeSophie/NewItemsIssue8676
N-thony Dec 6, 2023
4506227
Merge pull request #8661 from Patowhiz/PlotNullBug
N-thony Dec 7, 2023
0f75416
Merge pull request #8665 from derekagorhom/four_variable_Modelling
N-thony Dec 7, 2023
4c05087
added a check to avoid crashing
N-thony Dec 7, 2023
d2883e0
Merge pull request #102 from africanmathsinitiative/master
N-thony Dec 7, 2023
c2a80c9
Added back version number
N-thony Dec 7, 2023
1ab6816
Merge pull request #8680 from N-thony/version_number
conlooptechnologies Dec 7, 2023
5439433
Merge pull request #8649 from N-thony/returnFocus
conlooptechnologies Dec 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions instat/Model/DataFrame/clsColumnMetaData.vb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ Public Class clsColumnMetaData
Private Property _clsColsMetadataDataFrame As DataFrame
Private _hasChanged As Boolean

Private _useColumnSelectionInMetaData As Boolean

''' <summary>
''' holds the metadata change audit id
''' </summary>
Expand Down Expand Up @@ -107,8 +109,18 @@ Public Class clsColumnMetaData
_RLink = rLink
_strDataFrameName = strName
_hasChanged = True
_useColumnSelectionInMetaData = True
End Sub

Public Property UseColumnSelectionInMetaData() As Boolean
Get
Return _useColumnSelectionInMetaData
End Get
Set(value As Boolean)
_useColumnSelectionInMetaData = value
End Set
End Property

Private Function HasDataChanged() As Boolean
Dim clsVariablesMetadataChanged As New RFunction
Dim expTemp As SymbolicExpression
Expand Down Expand Up @@ -147,6 +159,8 @@ Public Class clsColumnMetaData
clsGetVariablesMetadata.SetRCommand(_RLink.strInstatDataObject & "$get_variables_metadata")
clsGetVariablesMetadata.AddParameter("convert_to_character", "TRUE")
clsGetVariablesMetadata.AddParameter("data_name", Chr(34) & _strDataFrameName & Chr(34))
'TODO. why not apply or not the column selection at the R level.
clsGetVariablesMetadata.AddParameter("use_column_selection", If(UseColumnSelectionInMetaData, "TRUE", "FALSE"))
expTemp = _RLink.RunInternalScriptGetValue(clsGetVariablesMetadata.ToScript(), bSilent:=True)
If expTemp IsNot Nothing AndAlso expTemp.Type <> Internals.SymbolicExpressionType.Null Then
Return expTemp.AsDataFrame
Expand Down
14 changes: 13 additions & 1 deletion instat/Model/DataFrame/clsDataFramePage.vb
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Public Class clsDataFramePage
Private _clsRDotNetDataFrame As DataFrame
Private _lstColumns As List(Of clsColumnHeaderDisplay)
Private _hasChanged As Boolean
Private _useColumnSelectionInDataView As Boolean

Private ReadOnly Property iColumnIncrements As Integer
Get
Expand Down Expand Up @@ -151,6 +152,7 @@ Public Class clsDataFramePage
_iColumnStart = 1
_iRowStart = 1
_hasChanged = True
_useColumnSelectionInDataView = True
End Sub

''' <summary>
Expand Down Expand Up @@ -184,6 +186,15 @@ Public Class clsDataFramePage
End If
End Sub

Public Property UseColumnSelectionInDataView() As Boolean
Get
Return _useColumnSelectionInDataView
End Get
Set(value As Boolean)
_useColumnSelectionInDataView = value
End Set
End Property

Private Function GetNoOfRowPages() As Integer
'Needs to be a function as the number of increments can be changed through options
Return Math.Ceiling(_iTotalRowCount / intRowIncrements)
Expand All @@ -201,7 +212,8 @@ Public Class clsDataFramePage
clsGetDataFrameRFunction.SetRCommand(_clsRLink.strInstatDataObject & "$get_data_frame")
clsGetDataFrameRFunction.AddParameter("convert_to_character", "TRUE")
clsGetDataFrameRFunction.AddParameter("use_current_filter", "TRUE")
clsGetDataFrameRFunction.AddParameter("use_column_selection", "TRUE")
'TODO. why not apply or not the column selection at the R level.
clsGetDataFrameRFunction.AddParameter("use_column_selection", If(UseColumnSelectionInDataView, "TRUE", "FALSE"))
clsGetDataFrameRFunction.AddParameter("max_cols", iColumnIncrements)
clsGetDataFrameRFunction.AddParameter("max_rows", intRowIncrements)
clsGetDataFrameRFunction.AddParameter("start_row", _iRowStart)
Expand Down
3 changes: 2 additions & 1 deletion instat/UserControls/DataGrid/ReoGrid/ucrDataViewReoGrid.vb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ Public Class ucrDataViewReoGrid

grdData.CurrentWorksheet.Columns = visiblePage.lstColumns.Count

If GetCurrentDataFrameFocus.clsFilterOrColumnSelection.bColumnSelectionApplied Then
If GetCurrentDataFrameFocus.clsFilterOrColumnSelection.bColumnSelectionApplied AndAlso
GetCurrentDataFrameFocus.clsVisibleDataFramePage.UseColumnSelectionInDataView Then
variableTextColour = Color.Red
Else
variableTextColour = Color.DarkBlue
Expand Down
3 changes: 2 additions & 1 deletion instat/clsDistribution.vb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Public Class Distribution
Public strDFunctionName As String = ""
Public strExactName As String = ""
Public strGLMFunctionName As String = ""
Public strAOVFunctionName As String = ""

Public bIncluded As Boolean = True
Public bNumeric As Boolean = False
Expand Down Expand Up @@ -77,7 +78,7 @@ Public Class Distribution
End Sub

Public Function IsDistributionFunction(strFunctionName As String) As Boolean
Dim strNames() As String = {strRFunctionName, strPFunctionName, strQFunctionName, strDFunctionName, strExactName, strGLMFunctionName}
Dim strNames() As String = {strRFunctionName, strPFunctionName, strQFunctionName, strDFunctionName, strExactName, strGLMFunctionName, strAOVFunctionName}
Return strNames.Contains(strFunctionName)
End Function
End Class
Expand Down
5 changes: 5 additions & 0 deletions instat/clsRLink.vb
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ Public Class RLink
''' <summary> The graph display option (e.g. 'view_output_window' or 'view_separate_window'). </summary>
Public strGraphDisplayOption As String = "view_output_window"

''' <summary> If true then show all the selected columns to the selector listview. </summary>
Public bUseColumnSelection As Boolean = False


''' <summary> The current grid (the worksheet that appears similar to a spreadsheet on the
''' left-hand side of the display). </summary>
Expand Down Expand Up @@ -1390,6 +1393,8 @@ Public Class RLink
Select Case strType
Case "column"
clsGetItems.SetRCommand(strInstatDataObject & "$get_column_names")
'TODO. why not apply or not the column selection at the R level.
clsGetItems.AddParameter("use_current_column_selection", If(bUseColumnSelection, "TRUE", "FALSE"))
Case "metadata"
clsGetItems.SetRCommand(strInstatDataObject & "$get_metadata_fields")
Case "filter"
Expand Down
10 changes: 8 additions & 2 deletions instat/clsRegressionDefaults.vb
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,20 @@ Public Class clsRegressionDefaults
End Property
Public Shared ReadOnly Property clsDefaultGlmFunction As RFunction
Get

Dim clsDefaultGlmFunc As New RFunction

clsDefaultGlmFunc.SetRCommand("glm")
Return clsDefaultGlmFunc
End Get
End Property

Public Shared ReadOnly Property clsDefaultAovFunction As RFunction
Get
Dim clsDefaultAovFunc As New RFunction
clsDefaultAovFunc.SetRCommand("aov")
Return clsDefaultAovFunc
End Get
End Property

Public Shared ReadOnly Property clsDefaultRGraphicsOperator As ROperator
Get

Expand Down
2 changes: 1 addition & 1 deletion instat/dlgBoxPlot.vb
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ Public Class dlgBoxplot
Else
ucrVariablesAsFactorForBoxplot.Add(clsParam.strArgumentValue)
End If
ElseIf clsParam.strArgumentName = "colour" Then
ElseIf clsParam.strArgumentName = "fill" Then
ucrSecondFactorReceiver.Add(clsParam.strArgumentValue)
End If
Next
Expand Down
Loading
Loading