Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ranks: AWS patches for migration (+ Go upgrade) #43

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

rraulinio
Copy link
Member

@rraulinio rraulinio commented Feb 4, 2025

Clickup ticket: https://app.clickup.com/t/86dvwymwd.

Details in the ticket.

TL;DR: Replace the current way AWS is doing the credentials parsing. Just let it do the work by itself. The underlying library has the correct logic for it by default.

@rraulinio rraulinio changed the title go-ranks - AWS patches for migration go-ranks: AWS patches for migration Feb 4, 2025
@klauspost
Copy link
Contributor

https://github.com/Vivino/rankdb/tree/master/.github/workflows needs an update too :)

@rraulinio
Copy link
Member Author

rraulinio commented Feb 4, 2025

Yep, then will address the golangci-lint issues.

@rraulinio rraulinio changed the title go-ranks: AWS patches for migration go-ranks: AWS patches for migration (+ Go upgrade) Feb 5, 2025
Copy link

@SerhiiKorolik SerhiiKorolik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rraulinio rraulinio added the do not merge Do not merge this PR yet label Feb 6, 2025
@rraulinio rraulinio removed the do not merge Do not merge this PR yet label Feb 7, 2025
@rraulinio rraulinio merged commit 9bd4981 into master Feb 7, 2025
4 checks passed
@rraulinio rraulinio deleted the CU-86dvwymwd_go-ranks---AWS-patches-for-migration branch February 7, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants