fix basic PUT users

Vizzuality · Jun 3, 2024 · 50eed02 · 50eed02
1 parent 51800ef
commit 50eed02
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/api/src/modules/users/users.controller.ts b/api/src/modules/users/users.controller.ts
@@ -10,6 +10,7 @@ import {
 import { UsersService } from './users.service';
 import { User } from '@shared/dto/users/user.entity';
 import { CreateUserDto } from '@shared/dto/users/create-user.dto';
+import { UpdateUserDto } from '@shared/dto/users/update-user.dto';
 
 @Controller('users')
 export class UsersController {
@@ -31,8 +32,8 @@ export class UsersController {
   }
 
   @Put(':id')
-  async update(@Param('id') id: string) {
-    return this.usersService.update(id);
+  async update(@Param('id') id: string, @Body() dto: UpdateUserDto) {
+    return this.usersService.update(id, dto);
   }
 
   @Delete(':id')

diff --git a/api/src/modules/users/users.service.ts b/api/src/modules/users/users.service.ts
@@ -3,6 +3,7 @@ import { User } from '@shared/dto/users/user.entity';
 import { CreateUserDto } from '@shared/dto/users/create-user.dto';
 import { Repository, DataSource } from 'typeorm';
 import { InjectRepository } from '@nestjs/typeorm';
+import { UpdateUserDto } from '@shared/dto/users/update-user.dto';
 
 @Injectable()
 export class UsersService {
@@ -25,15 +26,8 @@ export class UsersService {
     });
   }
 
-  async update(id: string) {
-    const found = this.userRepository.findOne({
-      where: { id },
-    });
-    if (!found) {
-      throw new NotFoundException(`User with ID "${id}" not found`);
-    }
-
-    return found;
+  async update(id: string, dto: UpdateUserDto) {
+    return this.userRepository.update(id, dto);
   }
 
   async remove(id: string) {