Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - implement screen when there is nothing to show #155

Merged

Conversation

atrincas
Copy link
Collaborator

@atrincas atrincas commented Nov 11, 2024

FE - implement screen when there is nothing to show

Designs

FIgma

Feature relevant tickets

SIRH-178

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-growth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:58pm

@agnlez
Copy link
Member

agnlez commented Nov 13, 2024

@atrincas in /sandbox, I would update the text with something like "to start, ...", some instructions so the user doesn't feel lost. Reading "there's no data" when the user never asked for data, it's a bit misleading, in my opinion.

Feel free to ask for the alternative text.

image

@atrincas
Copy link
Collaborator Author

@atrincas in /sandbox, I would update the text with something like "to start, ...", some instructions so the user doesn't feel lost. Reading "there's no data" when the user never asked for data, it's a bit misleading, in my opinion.

Feel free to ask for the alternative text.

image

My bad, forgot to change the text according to the design

@atrincas atrincas force-pushed the SIRH-178-fe-implement-screen-when-there-is-nothing-to-show branch from a98956e to 44057be Compare November 13, 2024 14:53
@atrincas atrincas merged commit c19f9f9 into dev Nov 13, 2024
5 checks passed
@atrincas atrincas deleted the SIRH-178-fe-implement-screen-when-there-is-nothing-to-show branch November 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants