Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid 500 error when API token have expired #1098

Merged
merged 6 commits into from
Dec 15, 2023
Merged

avoid 500 error when API token have expired #1098

merged 6 commits into from
Dec 15, 2023

Conversation

davidsingal
Copy link
Contributor

@davidsingal davidsingal commented Dec 12, 2023 •
edited
Loading

Fixing session issue in SSR when API token have expired.

Steps to replicate the issue:

  1. Log-in in the application
  2. Close the window once you got sign in
  3. Wait until API token is expired (2 min in dev temporally)
  4. Then, go to the url /analysis/map
  5. Ensure 500 error is not there anymore, it should redirect to sign in page

https://vizzuality.atlassian.net/browse/LANDGRIF-1506

@davidsingal davidsingal requested a review from alexeh December 12, 2023 22:32
@davidsingal davidsingal self-assigned this Dec 12, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 9:45am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 9:45am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 9:45am

@davidsingal davidsingal changed the title renew token automatically when token is expired renew token automatically when it's expired Dec 12, 2023
@davidsingal davidsingal changed the title renew token automatically when it's expired avoid 500 error when API token have expired Dec 15, 2023
@alexeh alexeh merged commit d2996e8 into dev Dec 15, 2023
4 of 5 checks passed
@andresgnlez andresgnlez deleted the client/fix/session-issue branch May 14, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeh alexeh alexeh approved these changes

Assignees

@davidsingal davidsingal

Labels
client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsingal @alexeh