Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANDGRIF-1509 Fix small number formatting #1113

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

BielStela
Copy link
Contributor

@BielStela BielStela commented Jan 18, 2024

Improve table/number readability. Avoid using m µ abbreviations for values < 1 and uses SI suffixes for > 1000.

@davidsingal I just applied the formatting to the legend component which I thick was the lowest hanging fruit of them all, if you can please do the same (or the proper way to do this) to the other places where we format would be nice :)

Updated for all cases.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 2:44pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 2:44pm
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 2:44pm

@BielStela BielStela requested a review from davidsingal January 18, 2024 11:01
@BielStela BielStela changed the title LANDGRIF-1509 Fixx small number formatting LANDGRIF-1509 Fix small number formatting Jan 18, 2024
@davidsingal davidsingal force-pushed the LANDGRIF-1509-improve-table-number branch from 3375082 to 4f0f050 Compare January 24, 2024 14:40
Copy link
Contributor

@davidsingal davidsingal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really well

@BielStela BielStela merged commit 9a9c1ed into dev Jan 24, 2024
5 checks passed
@BielStela BielStela deleted the LANDGRIF-1509-improve-table-number branch January 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants