Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] simplifies eslint configuration #1164

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

agnlez
Copy link
Member

@agnlez agnlez commented Apr 17, 2024

General description

This PR aims to simplify the current eslint configuration by:

  • removal of tsconfig.eslint.json middleware file.
  • updating eslint and its plugins/configs to latest versions.
  • removal of unnecessary plugins (like eslint-plugin-import, eslint-import-resolver-typescript) relying more on the NextJS out of the box configuration.
  • Additionally, now JS files are treated as ES-modules instead of CommonJS script for most of cases.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@agnlez agnlez self-assigned this Apr 17, 2024
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 10:31am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 10:31am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 10:31am

@agnlez agnlez force-pushed the chore/client/eslint-config branch from b6a09e6 to dc7fd99 Compare April 17, 2024 10:28
@agnlez agnlez merged commit 5ed626d into dev Apr 17, 2024
5 checks passed
@agnlez agnlez deleted the chore/client/eslint-config branch April 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant