-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike/landgrif 734 spike avoid stored function #591
Open
KevSanchez
wants to merge
8
commits into
dev
Choose a base branch
from
spike/LANDGRIF-734-spike-avoid-stored-function
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
KevSanchez
force-pushed
the
spike/LANDGRIF-734-spike-avoid-stored-function
branch
from
August 30, 2022 12:43
8fa4631
to
feaa324
Compare
…culation Now, wether the old stored functions, or the new API generated SQL queries are used for the calculations of indicator records at import time, is toggable via environment variable, SIMPLE_IMPORT_CALCULATIONS
… for all sourcing records The prototpye for for calculating all raw values for all sourcing records has revamped/polished to final status, with approval pending once tested. Also the the feature flag selection has been moved to sourcing data import along with a bit of refactoring.
KevSanchez
force-pushed
the
spike/LANDGRIF-734-spike-avoid-stored-function
branch
from
September 2, 2022 10:02
4db7945
to
4d0560b
Compare
…cords for troubleshooting
Not applicable anymore, as it wouldn't be possible to support the new indicator formula calculations. Will require further revision/rework. |
JoaquinTrinanes
force-pushed
the
dev
branch
2 times, most recently
from
November 8, 2022 12:51
309d795
to
e28efcb
Compare
alexeh
force-pushed
the
dev
branch
2 times, most recently
from
November 24, 2022 12:18
d508e0b
to
7801b9c
Compare
alexeh
force-pushed
the
dev
branch
3 times, most recently
from
November 28, 2022 08:14
e8879ad
to
bce34e8
Compare
davidsingal
force-pushed
the
dev
branch
2 times, most recently
from
December 1, 2022 10:36
b104ec6
to
467e5a3
Compare
alexeh
force-pushed
the
dev
branch
2 times, most recently
from
February 24, 2023 08:30
81763b1
to
f876633
Compare
alexeh
force-pushed
the
dev
branch
5 times, most recently
from
February 27, 2023 13:47
e072d47
to
0740fd3
Compare
alexeh
force-pushed
the
dev
branch
7 times, most recently
from
March 3, 2023 04:44
2fff34a
to
8a3eb61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General description
Proof of Concept to stop using the stored functions for impact calculation at import time, and instead use API programmatically generated queries. This feature is toggable via environment variable "SIMPLE_IMPORT_CALCULATIONS"; it's off by default, and true for test environment
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Provide minimal instructions on how to test this PR.
Checklist before merging