Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/landgrif 734 spike avoid stored function #591

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

KevSanchez
Copy link
Contributor

General description

Proof of Concept to stop using the stored functions for impact calculation at import time, and instead use API programmatically generated queries. This feature is toggable via environment variable "SIMPLE_IMPORT_CALCULATIONS"; it's off by default, and true for test environment

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated
landgriffon-client ⬜️ Ignored (Inspect) Sep 5, 2022 at 2:51PM (UTC)
landgriffon-marketing ⬜️ Ignored (Inspect) Sep 5, 2022 at 2:51PM (UTC)
landgriffon-marketing-v2 ⬜️ Ignored (Inspect) Sep 5, 2022 at 2:51PM (UTC)

@KevSanchez KevSanchez force-pushed the spike/LANDGRIF-734-spike-avoid-stored-function branch from 8fa4631 to feaa324 Compare August 30, 2022 12:43
@KevSanchez KevSanchez requested review from yulia-bel and alexeh August 30, 2022 12:43
alexeh and others added 7 commits September 2, 2022 11:33
…culation

Now, wether the old stored functions, or the new API generated SQL queries are used for the calculations of indicator records at import time, is toggable via environment variable, SIMPLE_IMPORT_CALCULATIONS
… for all sourcing records

The prototpye for for calculating all raw values for all sourcing records has revamped/polished to final status, with approval pending once tested. Also the the feature flag selection has been moved to sourcing data import along with a bit of refactoring.
@KevSanchez KevSanchez force-pushed the spike/LANDGRIF-734-spike-avoid-stored-function branch from 4db7945 to 4d0560b Compare September 2, 2022 10:02
@KevSanchez
Copy link
Contributor Author

Not applicable anymore, as it wouldn't be possible to support the new indicator formula calculations. Will require further revision/rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants